[Asterisk-code-review] loader: Remove global symbol only startup phase. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7986 )

Change subject: loader: Remove global symbol only startup phase.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I'm concerned that not having global symbol providers loaded first will negatively impact OPTIONAL_API consumer modules.

If a consumer of OPTIONAL_API functions is loaded before the module that exports the OPTIONAL_API symbols then will the consumer module only use the stub functions?

https://gerrit.asterisk.org/#/c/7986/1/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/7986/1/main/loader.c@1691
PS1, Line 1691: 	for (i = 0; !AST_LIST_EMPTY(&load_retries) && i < LOAD_RETRIES; i++) {
              : 		AST_LIST_TRAVERSE_SAFE_BEGIN(&load_retries, order, entry) {
We should change these loops to retry until there are no modules left in load_retries or no modules loaded in a loop.  If no modules loaded in a loop then do a final loop to not suppress load messages.

This fixed number of retries will fail if we have a chain of symbol dependent modules longer than the retry count and the modules are listed in the wrong order.

load_retries list with modules depending on the next module in the list:
A -> B -> C -> D -> E -> F

F loads, then E loads on the next time around because F is now loaded...



-- 
To view, visit https://gerrit.asterisk.org/7986
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33e3174d67f3b4552d3d536326dcaf0ebabb097d
Gerrit-Change-Number: 7986
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 17 Jan 2018 20:06:56 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180117/1ff520ff/attachment.html>