[Asterisk-code-review] loader: Add dependency fields to module structures. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7872 )

Change subject: loader: Add dependency fields to module structures.
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7872/6/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/7872/6/res/res_pjsip.c@5129
PS6, Line 5129: 	.optional_modules = "res_pjsip_config_wizard",
I don't think res_pjsip should need to know about this module.  Sorcery allows third party modules to add features like res_pjsip_config_wizard without needing to touch res_pjsip.

Shouldn't the .load_pri setting make the res_pjsip_config_wizard start before res_pjsip?  Either that or we would need res_pjsip_config_wizard to somehow declare that it enhances res_pjsip but must start before it.



-- 
To view, visit https://gerrit.asterisk.org/7872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf
Gerrit-Change-Number: 7872
Gerrit-PatchSet: 6
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 15 Jan 2018 05:39:59 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180114/51d81a94/attachment-0001.html>