[Asterisk-code-review] cdr syslog: Deprecate unmaintained module (asterisk[master])

[Jenkins2]

Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/7901 )

Change subject: cdr_syslog: Deprecate unmaintained module
......................................................................

cdr_syslog: Deprecate unmaintained module

There has been an open issue against cdr_syslog (ASTERISK~14441) about
a race condition for 7.5 years that has never been addressed. Because
this module is effectively unmaintained and currently broken, there is
no sense in keeping it around.

If logging CDRs to syslog is a desirable feature, it would probably be
better to write the logs directly to the syslog server via socket
instead of using the facilities provided by openlog/syslog/closelog.
Doing so would address the race condition referenced in the associated
issue.

Change-Id: Ic77b94cd97f355a9cf5b1d3f3444964a6e0ba5dc
---
M CHANGES
M UPGRADE.txt
M cdr/cdr_syslog.c
3 files changed, 11 insertions(+), 1 deletion(-)

Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/CHANGES b/CHANGES
index 84344aa..ec533e8 100644
--- a/CHANGES
+++ b/CHANGES
@@ -51,6 +51,11 @@
  * A new AMI action, PJSIPShowAuths, has been added which displays information
    about all configured PJSIP Auths.
 
+cdr_syslog
+------------------
+ * The cdr_syslog module is now deprecated and by default it is no longer
+   built.
+
 ------------------------------------------------------------------------------
 --- Functionality changes from Asterisk 15.1.0 to Asterisk 15.2.0 ------------
 ------------------------------------------------------------------------------
diff --git a/UPGRADE.txt b/UPGRADE.txt
index dd37b25..b2c75fb 100644
--- a/UPGRADE.txt
+++ b/UPGRADE.txt
@@ -40,6 +40,10 @@
  - The ContactInfo event's contact_status field is now set to "NonQualified"
    when a contact exists but has not been qualified.
 
+cdr_syslog:
+ - The cdr_syslog module is now deprecated and by default it is no longer
+   built.
+
 New in 15.0.0:
 
 Build System:
diff --git a/cdr/cdr_syslog.c b/cdr/cdr_syslog.c
index bbe2652..bbc4406 100644
--- a/cdr/cdr_syslog.c
+++ b/cdr/cdr_syslog.c
@@ -37,8 +37,9 @@
  */
 
 /*** MODULEINFO
+	<defaultenabled>no</defaultenabled>
 	<depend>syslog</depend>
-	<support_level>core</support_level>
+	<support_level>deprecated</support_level>
 ***/
 
 #include "asterisk.h"

-- 
To view, visit https://gerrit.asterisk.org/7901
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic77b94cd97f355a9cf5b1d3f3444964a6e0ba5dc
Gerrit-Change-Number: 7901
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180112/23d50d28/attachment.html>