[Asterisk-code-review] loader: Add dependency fields to module structures. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7872 )

Change subject: loader: Add dependency fields to module structures.
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/7872/2/include/asterisk/module.h
File include/asterisk/module.h:

https://gerrit.asterisk.org/#/c/7872/2/include/asterisk/module.h@348
PS2, Line 348: 	 * This field has is handled differently by the loader depending on if
s/has/""/


https://gerrit.asterisk.org/#/c/7872/2/include/asterisk/module.h@350
PS2, Line 350: 	 * 
extra space after '*'


https://gerrit.asterisk.org/#/c/7872/2/res/res_hep_rtcp.c
File res/res_hep_rtcp.c:

https://gerrit.asterisk.org/#/c/7872/2/res/res_hep_rtcp.c@187
PS2, Line 187: 	.requires = "res_pjsip",
Why does this require res_pjsip?


https://gerrit.asterisk.org/#/c/7872/2/res/res_pjsip_refer.c
File res/res_pjsip_refer.c:

https://gerrit.asterisk.org/#/c/7872/2/res/res_pjsip_refer.c@1232
PS2, Line 1232: 	.requires = "res_pjsip,res_pjsip_session",
This module currently requires res_pjsip_pubsub (see ASTERISK-27481). However, I'm not sure if we want to go ahead and add it here now, or probably want to wait until resolution of the mentioned issue?



-- 
To view, visit https://gerrit.asterisk.org/7872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf
Gerrit-Change-Number: 7872
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 11 Jan 2018 21:11:26 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180111/e2bb159e/attachment-0001.html>