[Asterisk-code-review] channels/SIP/ami/sip notify/call id: 3PCC patch for AMI "SIP... (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7705 )

Change subject: channels/SIP/ami/sip_notify/call_id: 3PCC patch for AMI "SIPnotify".
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Unfortunately this test is still not stopping correctly.  Here is the output I received (double-spacing stripped):
--> Running test 'tests/channels/SIP/ami/sip_notify/call_id' ...
Making sure Asterisk isn't running ...
Making sure SIPp isn't running...
Running ['tests/channels/SIP/ami/sip_notify/call_id/run-test'] ...
[Jan 11 12:55:05] WARNING[19540]: asterisk.test_case:531 _reactor_timeout: Reactor timeout: '10' seconds
[Jan 11 12:55:05] WARNING[19540]: asterisk.sipp:862 stop_asterisk: SIPp Scenario caller.xml has not exited; killing
[Jan 11 12:55:05] WARNING[19540]: asterisk.sipp:488 kill: Killing SIPp Scenario caller.xml
[Jan 11 12:55:05] WARNING[19540]: asterisk.sipp:862 stop_asterisk: SIPp Scenario callee.xml has not exited; killing
[Jan 11 12:55:05] WARNING[19540]: asterisk.sipp:488 kill: Killing SIPp Scenario callee.xml
Test ['tests/channels/SIP/ami/sip_notify/call_id/run-test', 'GIT-master-8a6febd980'] passed

https://gerrit.asterisk.org/#/c/7705/3/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml
File tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml:

https://gerrit.asterisk.org/#/c/7705/3/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml@8
PS3, Line 8:     minversion: '12.0.0'
Sorry I missed this earlier but this is the incorrect version for this test.  The Call-ID feature is only in 'master' so minversion is 16.0.0.  Once this test is fully functional I have no problems with cherry-picking the feature to 13 and 15.  In that case you would want:
minversion: ['13.20.0', '15.3.0', '16.0.0']



-- 
To view, visit https://gerrit.asterisk.org/7705
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccbf32ed6670a5205ee99bd7413c7fe0804efb1
Gerrit-Change-Number: 7705
Gerrit-PatchSet: 3
Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Comment-Date: Thu, 11 Jan 2018 17:57:36 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180111/09216f6f/attachment-0001.html>