[Asterisk-code-review] General: Silence modules on (un)load. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7828 )

Change subject: General: Silence modules on (un)load.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7828/1/res/res_curl.c
File res/res_curl.c:

https://gerrit.asterisk.org/#/c/7828/1/res/res_curl.c@a63
PS1, Line 63: 
I think this error is still needed but we can make it conditional.  Example if someone manually runs 'module unload res_curl.so', this error gives helpful information.

So instead of removing this error put it in 'if (!ast_shutting_down()) { ast_log() }'.  That way the message isn't produced during shutdown since the shutdown process has a loop which will retry the unload (hopefully after dependents are unloaded).



-- 
To view, visit https://gerrit.asterisk.org/7828
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f105f46d72553994e820679bfde3478a551b281
Gerrit-Change-Number: 7828
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 05 Jan 2018 17:45:50 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180105/c2c10a36/attachment.html>