[Asterisk-code-review] chan ooh323: Limit outgoinglimit to positive values as inten... (asterisk[master])

Corey Farrell asteriskteam at digium.com
Fri Jan 5 11:38:52 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7825 )

Change subject: chan_ooh323: Limit outgoinglimit to positive values as intended.
......................................................................


Patch Set 2: Code-Review+1

Normally I'd ask you to replace use of atoi with ast_parse_arg instead since atoi does not deal with errrors, but this is chan_ooh323 so I'm indifferent.

Giving +1 since this is an improvement.


-- 
To view, visit https://gerrit.asterisk.org/7825
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbf9d51e7374ca2e8b27ec568f6770050fc1a854
Gerrit-Change-Number: 7825
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 05 Jan 2018 17:38:52 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180105/3ce8dcf5/attachment.html>


More information about the asterisk-code-review mailing list