[Asterisk-code-review] astobj2: Create case-insensitive variants of container funct... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7774 )

Change subject: astobj2: Create case-insensitive variants of container function macros.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/7774/1/include/asterisk/astobj2.h
File include/asterisk/astobj2.h:

https://gerrit.asterisk.org/#/c/7774/1/include/asterisk/astobj2.h@2093
PS1, Line 2093: 		cmp = partial_key_cmp(object_left->field, right_key, strlen(right_key)); \
> I think this goes with the first comment - do we want to add the complexity
I suppose not.  These macros are best for the most common case of a string container key.  The partial key search is rarely needed for containers and is inefficient with hash containers anyway.



-- 
To view, visit https://gerrit.asterisk.org/7774
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I11af8c6a0c43380a42732553f519c667abb842cf
Gerrit-Change-Number: 7774
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 02 Jan 2018 20:50:55 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180102/6c9af756/attachment.html>