[Asterisk-code-review] func audiohookinherit: Remove deprecated module. (asterisk[master])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/8371 )

Change subject: func_audiohookinherit: Remove deprecated module.
......................................................................

func_audiohookinherit: Remove deprecated module.

Change-Id: Id52f719078a65c4b2eee7ab99d761eba6b6aed94
---
M CHANGES
D funcs/func_audiohookinherit.c
2 files changed, 7 insertions(+), 89 deletions(-)

Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/CHANGES b/CHANGES
index 2d49c13..66ffca5 100644
--- a/CHANGES
+++ b/CHANGES
@@ -74,12 +74,19 @@
  * The res_pjsip_registrar_expire module has been removed.  The functionality has
    been moved into res_pjsip_registrar.
 
+func_audiohookinherit
+------------------
+ * The func_audiohookinherit module has been removed. Due to architectural changes
+   in Asterisk 12, audiohook inheritance is performed automatically and this
+   function now lacks function.
+
 cdr_syslog
 ------------------
  * The cdr_syslog module is now deprecated and by default it is no longer
    built.
 
 Core:
+------------------
  * libedit is no longer available as an embedded library and must be provided
    by the system.
 
diff --git a/funcs/func_audiohookinherit.c b/funcs/func_audiohookinherit.c
deleted file mode 100644
index 2d79aba..0000000
--- a/funcs/func_audiohookinherit.c
+++ /dev/null
@@ -1,89 +0,0 @@
-/*
- * Asterisk -- An open source telephony toolkit.
- *
- * Copyright (C) 2008, Digium, Inc.
- *
- * Mark Michelson <mmichelson at digium.com>
- *
- * See http://www.asterisk.org for more information about
- * the Asterisk project. Please do not directly contact
- * any of the maintainers of this project for assistance;
- * the project provides a web site, mailing lists and IRC
- * channels for your use.
- *
- * This program is free software, distributed under the terms of
- * the GNU General Public License Version 2. See the LICENSE file
- * at the top of the source tree.
- *
- * Please follow coding guidelines
- * http://svn.digium.com/view/asterisk/trunk/doc/CODING-GUIDELINES
- */
-
-/*! \file
- *
- * \brief Audiohook inheritance function
- *
- * \author Mark Michelson <mmichelson at digium.com>
- *
- * \ingroup functions
- */
-
-/*** MODULEINFO
-	<support_level>deprecated</support_level>
- ***/
-
-#include "asterisk.h"
-#include "asterisk/channel.h"
-#include "asterisk/logger.h"
-#include "asterisk/pbx.h"
-#include "asterisk/module.h"
-
-/*** DOCUMENTATION
-	<function name = "AUDIOHOOK_INHERIT" language="en_US">
-		<synopsis>
-			DEPRECATED: Used to set whether an audiohook may be inherited to another
-			channel. Due to architectural changes in Asterisk 12, audiohook inheritance
-			is performed automatically and this function now lacks function.
-		</synopsis>
-		<description>
-			<para>Prior to Asterisk 12, masquerades would occur under all sorts of
-			situations which were hard to predict.  In Asterisk 12, masquerades only
-			occur as a result of a small set of operations for which inheriting all
-			audiohooks from the original channel is now safe.  So in Asterisk 12.5+,
-			all audiohooks are inherited without needing other controls expressing
-			which audiohooks should be inherited under which conditions.</para>
-		</description>
-	</function>
- ***/
-
-static int func_inheritance_write(struct ast_channel *chan, const char *function, char *data, const char *value)
-{
-	static int warned = 0;
-
-	if (!warned) {
-		ast_log(LOG_NOTICE, "AUDIOHOOK_INHERIT is deprecated and now does nothing.\n");
-		warned++;
-	}
-
-	return 0;
-}
-
-static struct ast_custom_function inheritance_function = {
-	.name = "AUDIOHOOK_INHERIT",
-	.write = func_inheritance_write,
-};
-
-static int unload_module(void)
-{
-	return ast_custom_function_unregister(&inheritance_function);
-}
-
-static int load_module(void)
-{
-	if (ast_custom_function_register(&inheritance_function)) {
-		return AST_MODULE_LOAD_DECLINE;
-	} else {
-		return AST_MODULE_LOAD_SUCCESS;
-	}
-}
-AST_MODULE_INFO_STANDARD_DEPRECATED(ASTERISK_GPL_KEY, "Audiohook inheritance placeholder function");

-- 
To view, visit https://gerrit.asterisk.org/8371
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id52f719078a65c4b2eee7ab99d761eba6b6aed94
Gerrit-Change-Number: 8371
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180223/d40473eb/attachment-0001.html>