[Asterisk-code-review] bridges/bridge simple.c: Protect calls to ast channel get st... (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8219 )

Change subject: bridges/bridge_simple.c: Protect calls to ast_channel_get_stream_topology
......................................................................


Patch Set 1: Verified-1 Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/8219/1/bridges/bridge_simple.c
File bridges/bridge_simple.c:

https://gerrit.asterisk.org/#/c/8219/1/bridges/bridge_simple.c@199
PS1, Line 199: 	ast_channel_lock(c0);
             : 	t0 = ast_channel_get_stream_topology(c0);
             : 	ast_channel_unlock(c0);
             : 
             : 	ast_channel_lock(c1);
             : 	t1 = ast_channel_get_stream_topology(c1);
             : 	ast_channel_unlock(c1);
The stream topology is not reference counted, so it is still possible for another thread to replace and then free this.



-- 
To view, visit https://gerrit.asterisk.org/8219
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f8766f0710765e0e88758c2a7aca33fa25ec0f7
Gerrit-Change-Number: 8219
Gerrit-PatchSet: 1
Gerrit-Owner: Jasper van der Neut <jasper at isotopic.nl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 16 Feb 2018 12:36:42 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180216/f5c629a1/attachment-0001.html>