[Asterisk-code-review] backtrace: Avoid potential spurious output. (asterisk[15])

Jenkins2 asteriskteam at digium.com
Mon Feb 12 06:18:53 CST 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8106 )

Change subject: backtrace: Avoid potential spurious output.
......................................................................

backtrace: Avoid potential spurious output.

clang 4.0 found this via -Wlogical-not-parentheses.

ASTERISK-27642

Change-Id: I9ec3e144d425a976c02811bd23cd0c533d2eca4e
---
M main/backtrace.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Corey Farrell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/main/backtrace.c b/main/backtrace.c
index aed4ffd..7dfcfc3 100644
--- a/main/backtrace.c
+++ b/main/backtrace.c
@@ -130,7 +130,7 @@
 			}
 
 			for (section = bfdobj->sections; section; section = section->next) {
-				if (!bfd_get_section_flags(bfdobj, section) & SEC_ALLOC ||
+				if (!(bfd_get_section_flags(bfdobj, section) & SEC_ALLOC) ||
 					section->vma > offset ||
 					section->size + section->vma < offset) {
 					continue;

-- 
To view, visit https://gerrit.asterisk.org/8106
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ec3e144d425a976c02811bd23cd0c533d2eca4e
Gerrit-Change-Number: 8106
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180212/d126abbe/attachment.html>


More information about the asterisk-code-review mailing list