[Asterisk-code-review] app amd: Infinite loop on silent calls (asterisk[16])

[Abhay Gupta]

Abhay Gupta has posted comments on this change. ( https://gerrit.asterisk.org/10736 )

Change subject: app_amd: Infinite loop on silent calls
......................................................................


Patch Set 1:

I do not understand what answer is being looked into . If res = -1 was not handled leading to infinite loop i put the code to handle that if you have a better way to handle then put it pls .

The next change that i did was for NULL frame . The code has handled the VOICE FRAME and CNG frame but not the NULL frame and so i put that and i do not understand the objection of saying why you handled NULL frame . Instead if you want then you should change it further to add warning or any better way in case a NULL frame occurs . The question is not why NULL frame can come or how res can be -1 but if the code handle all the conditions. 

The change is working well for me in production server and if you think it adds value to project pls do the needful .


-- 
To view, visit https://gerrit.asterisk.org/10736
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I24726bd29d7e467fc721ca265363417234b22855
Gerrit-Change-Number: 10736
Gerrit-PatchSet: 1
Gerrit-Owner: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 16:26:58 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181214/8d20f488/attachment-0001.html>