[Asterisk-code-review] stasis: Allow filtering by formatter (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10739 )

Change subject: stasis:  Allow filtering by formatter
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/10739/2/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/10739/2/main/stasis.c@897
PS2, Line 897: 	/*
             : 	 * The 'do while' gives us an easy way to skip remaining logic once
             : 	 * we determine the message should be accepted.
             : 	 * The code looks more verbose than it needs to be but it optimizes
             : 	 * down very nicely.  It's just easier to understand and debug this way.
             : 	 */
             : 	do {
> Instead of a do/while format why not just put this logic in a
 > separate aptly named function?

Keeps the logic where it's used and avoids another function call.


https://gerrit.asterisk.org/#/c/10739/2/tests/test_stasis.c
File tests/test_stasis.c:

https://gerrit.asterisk.org/#/c/10739/2/tests/test_stasis.c@2352
PS2, Line 2352: 	/* We should now have a second amievent */
> s/amievent/ami event

"amievent" refers to types->amievent.



-- 
To view, visit https://gerrit.asterisk.org/10739
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdb7a222a73b6b56c6bb9e4ee93dc8a394a5494c
Gerrit-Change-Number: 10739
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 12 Dec 2018 14:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181212/2504ea29/attachment.html>