[Asterisk-code-review] stasis: Allow filtering by formatter (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10739 )

Change subject: stasis:  Allow filtering by formatter
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Minor documentation tweak.

https://gerrit.asterisk.org/#/c/10739/1/include/asterisk/stasis_message_router.h
File include/asterisk/stasis_message_router.h:

https://gerrit.asterisk.org/#/c/10739/1/include/asterisk/stasis_message_router.h@255
PS1, Line 255:  */
I think it should be documented how this interacts with the default route a bit better.


https://gerrit.asterisk.org/#/c/10739/1/main/stasis_message.c
File main/stasis_message.c:

https://gerrit.asterisk.org/#/c/10739/1/main/stasis_message.c@86
PS1, Line 86: 	if (vtable->to_json) {
            : 		type->available_formatters |= STASIS_SUBSCRIPTION_FORMATTER_JSON;
            : 	}
            : 	if (vtable->to_ami) {
            : 		type->available_formatters |= STASIS_SUBSCRIPTION_FORMATTER_AMI;
            : 	}
            : 	if (vtable->to_event) {
            : 		type->available_formatters |= STASIS_SUBSCRIPTION_FORMATTER_EVENT;
            : 	}
Nice! It never occurred to me to stuff this info away like this.



-- 
To view, visit https://gerrit.asterisk.org/10739
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdb7a222a73b6b56c6bb9e4ee93dc8a394a5494c
Gerrit-Change-Number: 10739
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 14:30:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181206/14cc7566/attachment.html>