[Asterisk-code-review] test websocket client.c: Disable websocket client create and... (asterisk[13])

George Joseph asteriskteam at digium.com
Wed Dec 5 08:18:15 CST 2018


George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/10724 )

Change subject: test_websocket_client.c: Disable websocket_client_create_and_connect test.
......................................................................

test_websocket_client.c: Disable websocket_client_create_and_connect test.

This test was occasionally failing, with:

  WARNING[5812]: http.c:1939 httpd_helper_thread: Failed to set
      TCP_NODELAY on HTTP connection: Bad file descriptor
  ERROR[5812]: iostream.c:91 ast_iostream_nonblock: Failed to get
      fcntl() flags for file descriptor: Bad file descriptor
  ERROR[5812]: iostream.c:569 ast_iostream_close: close() failed: Bad
      file descriptor

Disabled for now by making the test explicit only.

Change-Id: I778f6cbb6104c6b4e89737a2eaf1a9540888d351
---
M tests/test_websocket_client.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Verified
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/tests/test_websocket_client.c b/tests/test_websocket_client.c
index dcf1a17..11c06ea 100644
--- a/tests/test_websocket_client.c
+++ b/tests/test_websocket_client.c
@@ -54,6 +54,7 @@
 	switch (cmd) {
 	case TEST_INIT:
 		info->name = __func__;
+		info->explicit_only = 1;
 		info->category = CATEGORY;
 		info->summary = "test creation and connection of a client websocket";
 		info->description = "test creation and connection of a client websocket";

-- 
To view, visit https://gerrit.asterisk.org/10724
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: I778f6cbb6104c6b4e89737a2eaf1a9540888d351
Gerrit-Change-Number: 10724
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181205/65ee614f/attachment.html>


More information about the asterisk-code-review mailing list