[Asterisk-code-review] http.c: Give HTTP error response when received lines are too... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10030 )

Change subject: http.c: Give HTTP error response when received lines are too long.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10030/1/main/http.c
File main/http.c:

https://gerrit.asterisk.org/#/c/10030/1/main/http.c@1783
PS1, Line 1783: 		len = strlen(header_line);
> Should this be strnlen() instead?
No because the buffer is always null terminated by fgets() when it returns non-NULL.



-- 
To view, visit https://gerrit.asterisk.org/10030
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df2705435fd7dde4d5d3bdf7acec859cfb7c12d
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 31 Aug 2018 15:43:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180831/2b494ac3/attachment.html>