[Asterisk-code-review] res pjsip: Implement additional SIP RFCs for Google Voice tr... (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Aug 30 08:37:43 CDT 2018


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/9505 )

Change subject: res_pjsip: Implement additional SIP RFCs for Google Voice trunk compatability
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.asterisk.org/#/c/9505/8/res/res_pjsip/config_transport.c
File res/res_pjsip/config_transport.c:

https://gerrit.asterisk.org/#/c/9505/8/res/res_pjsip/config_transport.c@313
PS8, Line 313: 		(pjsip_method_cmp(&tdata->msg->line.req.method, &pjsip_invite_method) && pjsip_method_cmp(&tdata->msg->line.req.method, &pjsip_cancel_method))) {
> did you intend to revert the addition of OPTIONS to this list from v7 (needed for qualify), or just  […]
Just a mis-merge, had an older copy in my dev environment. Fixed!



-- 
To view, visit https://gerrit.asterisk.org/9505
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58
Gerrit-Change-Number: 9505
Gerrit-PatchSet: 8
Gerrit-Owner: Nick French <naf at ou.edu>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Nick French <naf at ou.edu>
Gerrit-Comment-Date: Thu, 30 Aug 2018 13:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180830/ef795b62/attachment.html>


More information about the asterisk-code-review mailing list