[Asterisk-code-review] res parking: Increase size of parking space numbers (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/9933 )

Change subject: res_parking: Increase size of parking space numbers
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/9933/2/res/res_parking.c
File res/res_parking.c:

https://gerrit.asterisk.org/#/c/9933/2/res/res_parking.c@827
PS2, Line 827: 		arguments_string = ast_str_create(strlen(lot_cfg->name) + 1 + sizeof space);
> Revert this change.  This is the initial size of the created
 > ast_str.  It will dynamically grow as needed.

Using an ast_str is pointless here as we only set it once. arguments_string should be a char * and we should be using ast_asprintf() instead.



-- 
To view, visit https://gerrit.asterisk.org/9933
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbeee7546d5ab3ea3ce29c68b4810eb4e51decad
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 2
Gerrit-Owner: Karl Brose <karlbrose at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 23 Aug 2018 13:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180823/f507e5be/attachment.html>