[Asterisk-code-review] chan sip: remove unnecessary ast channel unlock(peer) as RA... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Wed Aug 22 12:53:04 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9988 )

Change subject: chan_sip:  remove unnecessary ast_channel_unlock(peer) as RAII looks after it
......................................................................


Patch Set 1:

> I checked and this is not applicable to those branches.

Yeah.  I was checking too.  The unlock was a leftover line when another patch went in.  Then a subsequent patch on pre-16 master needed to lock peer and thus fixed this issue on that branch.


-- 
To view, visit https://gerrit.asterisk.org/9988
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e45f2764ba4f3273a943300f91ac9b461ac2893
Gerrit-Change-Number: 9988
Gerrit-PatchSet: 1
Gerrit-Owner: Alec Davis <sivad.a at paradise.net.nz>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 17:53:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180822/97be82c0/attachment.html>


More information about the asterisk-code-review mailing list