[Asterisk-code-review] CI: Another stab at creds (asterisk[13])

Jenkins2 asteriskteam at digium.com
Thu Aug 16 13:10:41 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/9903 )

Change subject: CI: Another stab at creds
......................................................................

CI: Another stab at creds

Change-Id: I5b1dc3b354789e676c27a4e1fc42f5c3343cc994
---
M tests/CI/unittests.jenkinsfile
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Jenkins2: Looks good to me, approved; Approved for Submit



diff --git a/tests/CI/unittests.jenkinsfile b/tests/CI/unittests.jenkinsfile
index 332975c..4af9153 100644
--- a/tests/CI/unittests.jenkinsfile
+++ b/tests/CI/unittests.jenkinsfile
@@ -69,7 +69,6 @@
 					stage ("Checkout") {
 						sh "sudo chown -R jenkins:users ."
 						env.GERRIT_PROJECT_URL = env.GERRIT_CHANGE_URL.replaceAll(/\/[0-9]+$/, "/${env.GERRIT_PROJECT}")
-						sh "printenv | sort"
 
 						/*
 						 * Jenkins has already automatically checked out the base branch
@@ -85,7 +84,9 @@
 						 * in case this review is in a restricted project.
 						 */
 						withCredentials([usernamePassword(credentialsId: env.JENKINS_GERRIT_CREDS,
-							usernameVariable: 'gerrit_user')]) {
+							usernameVariable: 'GERRIT_USER_NAME')]) {
+
+							sh "printenv | sort"
 
 							checkout scm: [$class: 'GitSCM',
 								branches: [[name: env.GERRIT_BRANCH ]],
@@ -113,11 +114,12 @@
 									credentialsId: env.JENKINS_GERRIT_CREDS,
 									name: env.GERRIT_NAME,
 									refspec: env.GERRIT_REFSPEC,
-									url: env.GERRIT_PROJECT_URL.replaceAll("http(s)?://", "http\$1://${gerrit_user}@")
+									url: env.GERRIT_PROJECT_URL
 									]
 								]
 							]
 						}
+//						url: env.GERRIT_PROJECT_URL.replaceAll("http(s)?://", "http\$1://${env.GERRIT_USER_NAME}@")
 
 						sh "sudo tests/CI/setupJenkinsEnvironment.sh"
 					}

-- 
To view, visit https://gerrit.asterisk.org/9903
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b1dc3b354789e676c27a4e1fc42f5c3343cc994
Gerrit-Change-Number: 9903
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180816/7642ab16/attachment.html>


More information about the asterisk-code-review mailing list