[Asterisk-code-review] pbx config.c: Some modules not be loaded if they initially d... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/9883 )

Change subject: pbx_config.c: Some modules not be loaded if they initially decline to load
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/9883/3/pbx/pbx_config.c
File pbx/pbx_config.c:

https://gerrit.asterisk.org/#/c/9883/3/pbx/pbx_config.c@2100
PS3, Line 2100: 	if (pbx_load_module())
Shouldn't you move this to step 1 instead of doing a separate ast_config_load?  Should probably add unload_module() to the error path as well.



-- 
To view, visit https://gerrit.asterisk.org/9883
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00665106043b1be5148ffa7a477396038915854
Gerrit-Change-Number: 9883
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 15 Aug 2018 19:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180815/228ae622/attachment-0001.html>