[Asterisk-code-review] res odbc: Allow unload at shutdown. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Wed Aug 15 11:38:07 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/9876 )

Change subject: res_odbc: Allow unload at shutdown.
......................................................................


Patch Set 1:

I'm leaning towards not cherry-picking this to 13/15.  My reason is that the module loader in 16+ protects other modules with `.requires = "res_odbc".  13/15 might not include necessary reference counting to prevent res_odbc from unloading before modules which use it and I don't want to risk creating a situation where those modules crash on shutdown.

My plan is to make tests/CI/buildAsterisk.sh disable res_odbc if REF_DEBUG is enabled for 13/15.


-- 
To view, visit https://gerrit.asterisk.org/9876
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a3dea786bd6e7f4820a6dd5cbaa197fa783ce93
Gerrit-Change-Number: 9876
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 15 Aug 2018 16:38:07 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180815/2d837e13/attachment-0001.html>


More information about the asterisk-code-review mailing list