[Asterisk-code-review] translate: generic plc not filled in after translation (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8820 )

Change subject: translate: generic plc not filled in after translation
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/8820/1/formats/format_sln.c
File formats/format_sln.c:

https://gerrit.asterisk.org/#/c/8820/1/formats/format_sln.c@60
PS1, Line 60: 	if (f->datalen == 0) {
Add a comment about why this exists (should this be higher up?)


https://gerrit.asterisk.org/#/c/8820/1/main/translate.c
File main/translate.c:

https://gerrit.asterisk.org/#/c/8820/1/main/translate.c@534
PS1, Line 534: 	 * If we've gotten here then we should have an iterpolated frame that was not handled
interpolated


https://gerrit.asterisk.org/#/c/8820/1/main/translate.c@543
PS1, Line 543: 	res.subclass.format = ast_format_cache_get_slin_by_rate(8000); /* ref bumped on dup */
What happens with other sample rate paths?



-- 
To view, visit https://gerrit.asterisk.org/8820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I133d084da87adef913bf2ecc9c9240e3eaf4f40a
Gerrit-Change-Number: 8820
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 23 Apr 2018 13:02:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180423/ed5ceb2f/attachment-0001.html>