[Asterisk-code-review] chan ooh323: introduce localras config parameter (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/8812 )

Change subject: chan_ooh323: introduce localras config parameter
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8812/1/addons/ooh323c/src/ooGkClient.h
File addons/ooh323c/src/ooGkClient.h:

https://gerrit.asterisk.org/#/c/8812/1/addons/ooh323c/src/ooGkClient.h@225
PS1, Line 225: EXTERN int ooGkClientInit
             :    (enum RasGatekeeperMode eGkMode, char *szGkAddr, char *szRasAddr, int iGkPort );
I know this is master only, but are you sure you want to break the API? Would it be more feasible to deprecate the old function and create a new one in order to maintain backwards compatibility?

(dunno much about this channel driver and it's use or if it matters much here)



-- 
To view, visit https://gerrit.asterisk.org/8812
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b604b01793f3e02a776502659e07cd3fc7e3097
Gerrit-Change-Number: 8812
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Anikin <may213 at yandex.ru>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 23:16:36 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180419/15f5e5af/attachment.html>