[Asterisk-code-review] chan vpb: Avoid GNU old-style field designator extension. (asterisk[15])

Jenkins2 asteriskteam at digium.com
Thu Apr 19 15:50:05 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8787 )

Change subject: chan_vpb: Avoid GNU old-style field designator extension.
......................................................................

chan_vpb: Avoid GNU old-style field designator extension.

clang 6.0 warned about this. Beside that, this change removes the used variable
'desc'.

ASTERISK-27808

Change-Id: Ia26bdcc0a562c058151814511cfcf70ecafa595b
---
M channels/chan_vpb.cc
1 file changed, 62 insertions(+), 63 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Matthew Fredrickson: Looks good to me, but someone else must approve
  Richard Mudgett: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/channels/chan_vpb.cc b/channels/chan_vpb.cc
index 1736cc6..7fdb9ed 100644
--- a/channels/chan_vpb.cc
+++ b/channels/chan_vpb.cc
@@ -108,7 +108,6 @@
 #endif
 /**/
 
-static const char desc[] = "VoiceTronix V6PCI/V12PCI/V4PCI  API Support";
 static const char tdesc[] = "Standard VoiceTronix API Driver";
 static const char config[] = "vpb.conf";
 
@@ -360,71 +359,71 @@
 static int vpb_fixup(struct ast_channel *oldchan, struct ast_channel *newchan);
 
 static struct ast_channel_tech vpb_tech = {
-	type: "vpb",
-	description: tdesc,
-	capabilities: NULL,
-	properties: 0,
-	requester: vpb_request,
-	requester_with_stream_topology: NULL,
-	devicestate: NULL,
-	presencestate: NULL,
-	send_digit_begin: vpb_digit_begin,
-	send_digit_end: vpb_digit_end,
-	call: vpb_call,
-	hangup: vpb_hangup,
-	answer: vpb_answer,
-	read: vpb_read,
-	read_stream: NULL,
-	write: vpb_write,
-	write_stream: NULL,
-	send_text: NULL,
-	send_image: NULL,
-	send_html: NULL,
-	exception: NULL,
-	early_bridge: NULL,
-	indicate: vpb_indicate,
-	fixup: vpb_fixup,
-	setoption: NULL,
-	queryoption: NULL,
-	transfer: NULL,
-	write_video: NULL,
-	write_text: NULL,
-	func_channel_read: NULL,
-	func_channel_write: NULL,
+	.type = "vpb",
+	.description = tdesc,
+	.capabilities = NULL,
+	.properties = 0,
+	.requester = vpb_request,
+	.requester_with_stream_topology = NULL,
+	.devicestate = NULL,
+	.presencestate = NULL,
+	.send_digit_begin = vpb_digit_begin,
+	.send_digit_end = vpb_digit_end,
+	.call = vpb_call,
+	.hangup = vpb_hangup,
+	.answer = vpb_answer,
+	.read = vpb_read,
+	.read_stream = NULL,
+	.write = vpb_write,
+	.write_stream = NULL,
+	.send_text = NULL,
+	.send_image = NULL,
+	.send_html = NULL,
+	.exception = NULL,
+	.early_bridge = NULL,
+	.indicate = vpb_indicate,
+	.fixup = vpb_fixup,
+	.setoption = NULL,
+	.queryoption = NULL,
+	.transfer = NULL,
+	.write_video = NULL,
+	.write_text = NULL,
+	.func_channel_read = NULL,
+	.func_channel_write = NULL,
 };
 
 static struct ast_channel_tech vpb_tech_indicate = {
-	type: "vpb",
-	description: tdesc,
-	capabilities: NULL,
-	properties: 0,
-	requester: vpb_request,
-	requester_with_stream_topology: NULL,
-	devicestate: NULL,
-	presencestate: NULL,
-	send_digit_begin: vpb_digit_begin,
-	send_digit_end: vpb_digit_end,
-	call: vpb_call,
-	hangup: vpb_hangup,
-	answer: vpb_answer,
-	read: vpb_read,
-	read_stream: NULL,
-	write: vpb_write,
-	write_stream: NULL,
-	send_text: NULL,
-	send_image: NULL,
-	send_html: NULL,
-	exception: NULL,
-	early_bridge: NULL,
-	indicate: NULL,
-	fixup: vpb_fixup,
-	setoption: NULL,
-	queryoption: NULL,
-	transfer: NULL,
-	write_video: NULL,
-	write_text: NULL,
-	func_channel_read: NULL,
-	func_channel_write: NULL,
+	.type = "vpb",
+	.description = tdesc,
+	.capabilities = NULL,
+	.properties = 0,
+	.requester = vpb_request,
+	.requester_with_stream_topology = NULL,
+	.devicestate = NULL,
+	.presencestate = NULL,
+	.send_digit_begin = vpb_digit_begin,
+	.send_digit_end = vpb_digit_end,
+	.call = vpb_call,
+	.hangup = vpb_hangup,
+	.answer = vpb_answer,
+	.read = vpb_read,
+	.read_stream = NULL,
+	.write = vpb_write,
+	.write_stream = NULL,
+	.send_text = NULL,
+	.send_image = NULL,
+	.send_html = NULL,
+	.exception = NULL,
+	.early_bridge = NULL,
+	.indicate = NULL,
+	.fixup = vpb_fixup,
+	.setoption = NULL,
+	.queryoption = NULL,
+	.transfer = NULL,
+	.write_video = NULL,
+	.write_text = NULL,
+	.func_channel_read = NULL,
+	.func_channel_write = NULL,
 };
 
 #if defined(VPB_NATIVE_BRIDGING)

-- 
To view, visit https://gerrit.asterisk.org/8787
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia26bdcc0a562c058151814511cfcf70ecafa595b
Gerrit-Change-Number: 8787
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180419/5bda0da3/attachment.html>


More information about the asterisk-code-review mailing list