[Asterisk-code-review] * cdr mysql: Compile error because is misssing MYSQL PORT de... (asterisk[15])

[Evandro César Arruda]

Evandro César Arruda has posted comments on this change. ( https://gerrit.asterisk.org/8708 )

Change subject: * cdr_mysql: Compile error because is misssing MYSQL_PORT definition
......................................................................


Patch Set 4:

> > > Restore version 3
 > >
 > > Sean Bright are right about mysql.h... But MariaDB started use of
 > > MARIADB_PORT definition instead of MYSQL_PORT definition, we will
 > > have same problem on fedora tree and others like Corey told.
 > >
 > > If don't have MYSQL_PORT and MARIADB_PORT this system don't have
 > > mysql client installed.
 > >
 > > What you thing about it? See.. I commited better approach,
 > because
 > > ignoring MARIADB_PORT definition we may have problem in future.
 > 
 > * You can still wind up with MYSQL_PORT undefined and get a compile
 > error.  This would be better if you really want to go that route:
 > 
 > #if !defined(MYSQL_PORT)
 > #if defined(MARIADB_PORT)
 > #define MYSQL_PORT MARIADB_PORT
 > #else
 > #define MYSQL_PORT 3306
 > #endif
 > #endif
 > 
 > * You also reverted the commit message corrections I made.

I did something like this, but deleted, on my mind i was forcing some situation without mysql installed on system, but, it will fail if don't have mysql lib on system.

I will do like your suggestion. Sorry about comments, it's my first time here, on the past i did it using issues.digi... i'm learning about patch process. Sorry again, if can you help me with comments after next version commited i will appreciate.


-- 
To view, visit https://gerrit.asterisk.org/8708
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee56c836fc2e8bd021c456145bba04c6068bb77
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 4
Gerrit-Owner: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 20:13:22 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180411/d52c1d9a/attachment.html>