[Asterisk-code-review] sipp, test suite utils: Default media port to an unused port (testsuite[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/8689 )

Change subject: sipp, test_suite_utils: Default media port to an unused port
......................................................................


Patch Set 4:

(1 comment)

> (1 comment)
 > 
 > I'm leaving for vacation Wednesday and I'm too busy to give this a
 > proper review before I go, just wanted to mention the MIN_PORT
 > thing before I leave.

May your vacation be port free (unless you are going on a cruise).

https://gerrit.asterisk.org/#/c/8689/4/lib/python/asterisk/utils_socket.py
File lib/python/asterisk/utils_socket.py:

https://gerrit.asterisk.org/#/c/8689/4/lib/python/asterisk/utils_socket.py@26
PS4, Line 26: MIN_PORT = 1000
> Should this be bumped up to 10000 maybe?  This way we avoid ports in the 50
Makes sense to me. Will do.



-- 
To view, visit https://gerrit.asterisk.org/8689
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I3da461123afc30e1f5ca12e65d289eaa42d6de00
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 21:31:02 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180409/9e3e8912/attachment.html>