[Asterisk-code-review] * cdr mysql: Compile error because is misssing MYSQL PORT de... (asterisk[15])

[Evandro César Arruda]

Evandro César Arruda has posted comments on this change. ( https://gerrit.asterisk.org/8708 )

Change subject: * cdr_mysql: Compile error because is misssing MYSQL_PORT definition
......................................................................


Patch Set 2:

(1 comment)

> Fedora patches this by adding an include to mysql/mariadb_version.h
 > and using MARIADB_PORT instead of MYSQL_PORT.  Not sure it's worth
 > it to detect that header in the configure scripts and use `#define
 > MYSQL_PORT MARIADB_PORT`?
 > 
 > I really have no opinion on this just pointing out what Fedora
 > does.

Very nice information, thanks. Well, it's confirm my research. It isn't on MySQL/MariaDB tree... we will have the same problem with other linux distros (like Debian that i use).

I could change my patch to support both case (it will increase a few 'ifs' and lines of code, but ok...) Is it ok for you? May i proceed?

https://gerrit.asterisk.org/#/c/8708/1/addons/cdr_mysql.c
File addons/cdr_mysql.c:

https://gerrit.asterisk.org/#/c/8708/1/addons/cdr_mysql.c@60
PS1, Line 60: 
> Instead of always defining this I think it should only be defined if not al
Nice suggestion. I Agree. I will modify my patch. Thanks!



-- 
To view, visit https://gerrit.asterisk.org/8708
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee56c836fc2e8bd021c456145bba04c6068bb77
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 2
Gerrit-Owner: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 13:12:13 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180409/a0f9e34a/attachment.html>