[Asterisk-code-review] * cdr mysql: Compile error because is misssing MYSQL PORT de... (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8708 )

Change subject: * cdr_mysql: Compile error because is misssing MYSQL_PORT definition
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/8708/1/addons/cdr_mysql.c
File addons/cdr_mysql.c:

https://gerrit.asterisk.org/#/c/8708/1/addons/cdr_mysql.c@60
PS1, Line 60: #define MYSQL_PORT 3306
Instead of always defining this I think it should only be defined if not already present.



-- 
To view, visit https://gerrit.asterisk.org/8708
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee56c836fc2e8bd021c456145bba04c6068bb77
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 1
Gerrit-Owner: Evandro César Arruda <ecarruda at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 10:24:53 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180403/97015736/attachment.html>