[Asterisk-code-review] logger: Bring back ability to turn debug on by source file (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6618 )

Change subject: logger:  Bring back ability to  turn debug on by source file
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6618/1/main/cli.c
File main/cli.c:

https://gerrit.asterisk.org/#/c/6618/1/main/cli.c@154
PS1, Line 154: unsigned int ast_debug_get_by_file(const char *file)
             : {
             : 	struct module_level *ml;
             : 	unsigned int res = 0;
             : 
             : 	AST_RWLIST_RDLOCK(&debug_modules);
             : 	AST_LIST_TRAVERSE(&debug_modules, ml, entry) {
             : 		if (!strcasecmp(ml->module, file)) {
             : 			res = ml->level;
             : 			break;
             : 		}
             : 	}
             : 	AST_RWLIST_UNLOCK(&debug_modules);
             : 
             : 	return res;
             : }
> This appears to be the exact same code as ast_debug_get_module. You
 > should be able to dump this and just call that function.

Duh.  You're right.



-- 
To view, visit https://gerrit.asterisk.org/6618
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc0af41837f3b1679dec7af21fa32cd1f7469f6e
Gerrit-Change-Number: 6618
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 16:15:16 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170928/6f5185e1/attachment.html>