[Asterisk-code-review] webrtc: Allow 'webrtc' to be set on endpoints without dtls c... (asterisk[master])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/6594 )

Change subject: webrtc: Allow 'webrtc' to be set on endpoints without dtls_ca_file
......................................................................

webrtc: Allow 'webrtc' to be set on endpoints without dtls_ca_file

If using a legitimate certificate from a trusted certificate authority,
you don't need to provide CA file.

Change-Id: I8623973b4209b44889243716d7880274caed8a6d
---
M res/res_pjsip/pjsip_configuration.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, approved



diff --git a/res/res_pjsip/pjsip_configuration.c b/res/res_pjsip/pjsip_configuration.c
index cba8a7e..3a752c9 100644
--- a/res/res_pjsip/pjsip_configuration.c
+++ b/res/res_pjsip/pjsip_configuration.c
@@ -1363,10 +1363,9 @@
 		endpoint->media.rtp.dtls_cfg.default_setup = AST_RTP_DTLS_SETUP_ACTPASS;
 		endpoint->media.rtp.dtls_cfg.verify = AST_RTP_DTLS_VERIFY_FINGERPRINT;
 
-		if (ast_strlen_zero(endpoint->media.rtp.dtls_cfg.certfile) ||
-			(ast_strlen_zero(endpoint->media.rtp.dtls_cfg.cafile))) {
+		if (ast_strlen_zero(endpoint->media.rtp.dtls_cfg.certfile)) {
 			ast_log(LOG_ERROR, "WebRTC can't be enabled on endpoint '%s' - a DTLS cert "
-				"or ca file has not been specified", ast_sorcery_object_get_id(endpoint));
+				"has not been specified", ast_sorcery_object_get_id(endpoint));
 			return -1;
 		}
 	}

-- 
To view, visit https://gerrit.asterisk.org/6594
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8623973b4209b44889243716d7880274caed8a6d
Gerrit-Change-Number: 6594
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170926/d0e7eec1/attachment.html>