[Asterisk-code-review] res pjsip session: outgoing call did not offer all configure... (asterisk[15.0])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6572 )

Change subject: res_pjsip_session: outgoing call did not offer all configured codecs
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I don't think this is the right way to fix this. Take the video case. With that you really only do want the requested format, because you can't transcode. I see two possible ways forward on this:

1. For audio streams we update it to include all configured audio formats, not just what was requested.

2. We make it so that the format capabilities represent the requested + what we can transcode for all stream types. In cases where we can't transcode it'll stay with what was requested since we know the requester can do it.

https://gerrit.asterisk.org/#/c/6572/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6572/1/res/res_pjsip_session.c@2408
PS1, Line 2408: 				endpoint->media.codecs, AST_MEDIA_TYPE_UNKNOWN);
A stream can only carry one type of media. You can't have formats of different types in it.



-- 
To view, visit https://gerrit.asterisk.org/6572
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15.0
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffabc373bd94cd1dc700925dcfe406e12918c696
Gerrit-Change-Number: 6572
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 25 Sep 2017 11:25:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170925/da9cff55/attachment.html>