[Asterisk-code-review] res pjsip session: outgoing call did not offer all configure... (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6569 )

Change subject: res_pjsip_session: outgoing call did not offer all configured codecs
......................................................................


Patch Set 2: Code-Review-1

I think this needs to be rethought.

For an initial outgoing INVITE the offered codecs should be the intersection of the calling channel's codecs and the endpoint's configured codecs.  Probably if the resulting set is empty we should offer the endpoint's configured codecs.  I do know that if we unconditionally offered the endpoint's configured codecs we have received complaints about unnecessary codec translations.

For a reINVITE, I'm not sure what we should really do.  Take the intersection of the bridged peer's codecs and the channel's currently negotiated codecs.  If it results in an empty set then either don't change the current codecs or offer the endpoint's configured codecs.

Setting to -1 so the comment is not overlooked.


-- 
To view, visit https://gerrit.asterisk.org/6569
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffabc373bd94cd1dc700925dcfe406e12918c696
Gerrit-Change-Number: 6569
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 22:50:11 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170922/0b8a7a86/attachment.html>