[Asterisk-code-review] app queue: Only do announcement logic between ringing cycles (asterisk[13])

[Stefan Engström]

Stefan Engström has posted comments on this change. ( https://gerrit.asterisk.org/6506 )

Change subject: app_queue: Only do announcement logic between ringing cycles
......................................................................


Patch Set 3:

Yes, patch set 3 makes more sense. I don't know the background story for the "announce_to_first_user" attribute but I guess it should prevent both position and periodic announcements to first_user/head caller. patch set 3 has been tested live for about 2 days now, so feel free to review again. If patch set 3 gets accepted, will that automatically be cherry picked to asterisk 15? Currently patch set 1 is cherry picked?


-- 
To view, visit https://gerrit.asterisk.org/6506
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4290dc75256f9743900c6762ee1bb915f672db0
Gerrit-Change-Number: 6506
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Engström <stefanen at kth.se>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Stefan Engström <stefanen at kth.se>
Gerrit-Comment-Date: Fri, 22 Sep 2017 16:31:08 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170922/0f3c0107/attachment.html>