[Asterisk-code-review] res pjsip session: Change some asserts to warning/debug mes... (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6548 )

Change subject: res_pjsip_session:  Change some asserts to warning/debug messages
......................................................................


Patch Set 2: Code-Review-1

I don't think these are user friendly for when they appear (in particular the warning messages). The information is certainly there but it's scary. I think some rewording needs to be done.

For example:
Local SDP for channel contains n number of media streams while we expected it to contain n.


-- 
To view, visit https://gerrit.asterisk.org/6548
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I58daaa9d2938fa980857ab3ec41925ab5ff9c848
Gerrit-Change-Number: 6548
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 14:47:05 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170921/af634391/attachment.html>