[Asterisk-code-review] Modules: Additional improvements to CLI completion. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Tue Oct 31 12:12:17 CDT 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6942 )

Change subject: Modules: Additional improvements to CLI completion.
......................................................................


Patch Set 1: Code-Review-1

> What did the commands show before?
 > When I type "module load res_pjsip<tab>" I get all res_pjsip
 > modules, including res_pjsip itself.  Shouldn't only modules that
 > CAN be loaded be shown?

'module load' still shows all modules that match by filename (even loaded ones), so I still need to work on this.  -1'ing my own review until I can either fix 'module load' completion or remove it's mention from the commit msg.


-- 
To view, visit https://gerrit.asterisk.org/6942
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea3e00054461484196c46f688f02635cc886bad1
Gerrit-Change-Number: 6942
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 31 Oct 2017 17:12:17 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171031/569dfd48/attachment.html>


More information about the asterisk-code-review mailing list