[Asterisk-code-review] res pjsip: Add 'ip' as a valid option to 'identify by' on en... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/6905 )

Change subject: res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/6905/3/res/res_pjsip_endpoint_identifier_ip.c
File res/res_pjsip_endpoint_identifier_ip.c:

https://gerrit.asterisk.org/#/c/6905/3/res/res_pjsip_endpoint_identifier_ip.c@232
PS3, Line 232: 		if (!(endpoint->ident_method & AST_SIP_ENDPOINT_IDENTIFY_BY_IP)) {
             : 			ast_debug(3, "Endpoint '%s' found for '%s' but 'ip' method not supported'\n", match->endpoint_name,
             : 				ast_sockaddr_stringify(&addr));
             : 			ao2_cleanup(endpoint);
             : 			return NULL;
             : 		}
> The ident_by_user_only tests this scenario.
Okay I think I see now. The default global endpoint identifier order is "ip,username,anonymous". I thought it was "username,ip". So the test will first match on the ip and get the invalid endpoint, but go into the "not supported" condition. Then it'll try by username and match.



-- 
To view, visit https://gerrit.asterisk.org/6905
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2170b86a7f7e221b4f00bf14aa1ef1ac5b050bbd
Gerrit-Change-Number: 6905
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 26 Oct 2017 22:17:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171026/21a53e12/attachment-0001.html>