[Asterisk-code-review] pjsip: Add test for 'ip' option of 'identify by' on endpoint. (testsuite[master])

George Joseph asteriskteam at digium.com
Wed Oct 25 13:21:54 CDT 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6908 )

Change subject: pjsip: Add test for 'ip' option of 'identify_by' on endpoint.
......................................................................


Patch Set 1:

Doesn't this test also need to test that if ip is NOT specified (only username) we fail?


-- 
To view, visit https://gerrit.asterisk.org/6908
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4e504b0063c723f6cdafd0f78281e33027f7ac
Gerrit-Change-Number: 6908
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 25 Oct 2017 18:21:54 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171025/fc4f23e9/attachment.html>


More information about the asterisk-code-review mailing list