[Asterisk-code-review] res pjsip: Add 'ip' as a valid option to 'identify by' on en... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6905 )

Change subject: res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I think the sample config probably needs an update as well.

https://gerrit.asterisk.org/#/c/6905/1/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/6905/1/res/res_pjsip.c@274
PS1, Line 274: 						Endpoints and aors can be identified in multiple ways. Currently, the supported
I think an explanation that this option serves 2 purposes is in order.  First, it restricts which methods from the global identify_by option can be used to match this endpoint, and second, how inbound registration matches an aor to this endpoint.  A mention that inbound registration needs at least one method other than "ip" is also needed.



-- 
To view, visit https://gerrit.asterisk.org/6905
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2170b86a7f7e221b4f00bf14aa1ef1ac5b050bbd
Gerrit-Change-Number: 6905
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 25 Oct 2017 14:08:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171025/295423ad/attachment.html>