[Asterisk-code-review] alembic: Add bundle column in ps endpoints table (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6903 )

Change subject: alembic: Add bundle column in ps_endpoints table
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6903/1/contrib/ast-db-manage/config/versions/de83fac997e2_add_bundle_to_ps_endpoints.py
File contrib/ast-db-manage/config/versions/de83fac997e2_add_bundle_to_ps_endpoints.py:

https://gerrit.asterisk.org/#/c/6903/1/contrib/ast-db-manage/config/versions/de83fac997e2_add_bundle_to_ps_endpoints.py@18
PS1, Line 18:     op.add_column('ps_endpoints', sa.Column('bundle', sa.Integer))
I don't think integer is the correct type. The option follows yes/no like others.



-- 
To view, visit https://gerrit.asterisk.org/6903
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic900f4f2c20f64b99ea898d50f5c0a7117472d46
Gerrit-Change-Number: 6903
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 25 Oct 2017 10:28:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171025/0d52b951/attachment.html>