[Asterisk-code-review] res pjsip session: Rewrite o= with external media address. (asterisk[13])

Jenkins2 asteriskteam at digium.com
Tue Oct 17 06:26:48 CDT 2017


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/6793 )

Change subject: res_pjsip_session: Rewrite o= with external_media_address.
......................................................................

res_pjsip_session: Rewrite o= with external_media_address.

PJSIP allows a domain name as external_media_address. This allows chan_pjsip to
be used behind a NAT with changing IP addresses. The IP address of that domain
is resolved to the c= line already. This change sets also the o= line to that
domain.

ASTERISK-27341 #close

Change-Id: I690163b6e762042ec38b3995aa5c9bea909d8ec4
---
M res/res_pjsip_session.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c
index eb16125..c53d52d 100644
--- a/res/res_pjsip_session.c
+++ b/res/res_pjsip_session.c
@@ -3136,6 +3136,7 @@
 		if (ast_sip_transport_is_local(transport_state, &our_sdp_addr) || !transport_state->localnet) {
 			ast_debug(5, "Setting external media address to %s\n", ast_sockaddr_stringify_host(&transport_state->external_media_address));
 			pj_strdup2(tdata->pool, &sdp->conn->addr, ast_sockaddr_stringify_host(&transport_state->external_media_address));
+			pj_strdup2(tdata->pool, &sdp->origin.addr, transport->external_media_address);
 		}
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/6793
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: I690163b6e762042ec38b3995aa5c9bea909d8ec4
Gerrit-Change-Number: 6793
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171017/ff0cf49a/attachment.html>


More information about the asterisk-code-review mailing list