[Asterisk-code-review] pjproject bundled: Disable TCP/TLS keep-alives. (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/6807 )

Change subject: pjproject_bundled: Disable TCP/TLS keep-alives.
......................................................................


Patch Set 1:

Yes, I got your fear. However, I cannot change to something I consider wrong. Furthermore, I do not benefit from this change at all because I do not use the bundled PJProject.

Even worse, I would have to change my configurations if I go for your proposal. I love to help and contribute but there are limits. There is no benefit in for me, actually I face drawbacks. I rather change all other deployments instead of changing my configurations. Those who rely on it unknowingly should wake up – questionable if there is anyone who has to wake up.

Thanks for PJSIP_TRANSPORT_IDLE_TIME. Puh. I certainly have to look into that and whether my UAC connection(s) are maintained just as long as that or longer. Sounds like a keep-alive of 90 seconds would not help then either. Yet, another flag to change at compile time…


-- 
To view, visit https://gerrit.asterisk.org/6807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I27c7a87c882b02f56ff3b739630d9b9e5912cc68
Gerrit-Change-Number: 6807
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 16 Oct 2017 13:05:51 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171016/eb2d4d0c/attachment-0001.html>