[Asterisk-code-review] res pjsip: Fix issues that prevented shutdown of modules. (asterisk[master])
George Joseph
asteriskteam at digium.com
Fri Oct 6 12:48:12 CDT 2017
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6647 )
Change subject: res_pjsip: Fix issues that prevented shutdown of modules.
......................................................................
Patch Set 1:
> > Are you thinking this is too invasive for 13 and 14?
>
> I don't. I just haven't posted for 13/14 because it doesn't
> cleanly cherry-pick, so I'd like to get comments on the changes
> before I do that work. I think the change is worth it. Since the
> policy is that we allow new features to 13/14 as long as we have
> tests, I think this change is necessary to verify that new features
> don't leak.
Gotcha, makes sense. I'll look in detail this afternoon.
--
To view, visit https://gerrit.asterisk.org/6647
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbd5c19ec848010111afeab2436f9699da06ba6b
Gerrit-Change-Number: 6647
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 06 Oct 2017 17:48:12 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171006/c1990792/attachment-0001.html>
More information about the asterisk-code-review
mailing list