[Asterisk-code-review] res pjsip registrar.c: Update remove existing AOR contact ha... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6630 )

Change subject: res_pjsip_registrar.c: Update remove_existing AOR contact handling.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/6630/1/CHANGES
File CHANGES:

https://gerrit.asterisk.org/#/c/6630/1/CHANGES@37
PS1, Line 37:  * The "remove_existing" option now removes the soonest to expire contacts a
This sentence doesn't parse.


https://gerrit.asterisk.org/#/c/6630/1/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/#/c/6630/1/configs/samples/pjsip.conf.sample@897
PS1, Line 897: ;remove_existing=no     ; Determines whether new contacts remove the number of
             :                         ; existing ones over max_contacts which expire the soonest.
I think this needs to be reworded or extended to be clearer. It's... not easy to read and comprehend.


https://gerrit.asterisk.org/#/c/6630/1/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/6630/1/res/res_pjsip.c@1412
PS1, Line 1412: 						registers random contact addresses to help with NAT and reusing
That's not really what it does. It rewrites the contact to the source IP address and port, it's not random.



-- 
To view, visit https://gerrit.asterisk.org/6630
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I64c107a10b70db1697d17136051ae6bf22b5314b
Gerrit-Change-Number: 6630
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 13:20:23 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171004/7328c5c6/attachment-0001.html>