[Asterisk-code-review] core: Use ast alertpipe for Asterisk signal monitoring thread. (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Mon Nov 13 17:39:08 CST 2017


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7169 )

Change subject: core: Use ast_alertpipe for Asterisk signal monitoring thread.
......................................................................


Patch Set 2:

After a chat on IRC the code is correct, but it was agreed that the docs should be updated, so leaving a -1 for that for now:

Corey Farrell wrote:
> actually I think the docs should be changed.  the number of bytes are determined by 'uint64_t tmp = 1;' inside the function, so it's an implementation detail.


-- 
To view, visit https://gerrit.asterisk.org/7169
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4041a237d481ff699639e153ea6982fee14a462
Gerrit-Change-Number: 7169
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 13 Nov 2017 23:39:08 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171113/e2d0e4e7/attachment.html>


More information about the asterisk-code-review mailing list