[Asterisk-code-review] sorcery: Add ast sorcery retrieve by prefix() (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/7162 )

Change subject: sorcery: Add ast_sorcery_retrieve_by_prefix()
......................................................................


Patch Set 4:

> (1 comment)
 > 
 > The -1 is not about the retrieve_regex fallback comment, I'm not
 > sure that's worth a -1.  See the master review for real findings.

The only wizards that don't implement _prefix (after this patch) are out-of-tree modules and I don't really care.

The problem with falling back to regular expressions, is that you can't naively just tack a ^ on the front of a string and expect that to be a valid regular expression. We would have to look for and escape metacharacters so that they do not match when they shouldn't.


-- 
To view, visit https://gerrit.asterisk.org/7162
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I56f4e20ba1154bd52281f995c27a429a854f6a79
Gerrit-Change-Number: 7162
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 13 Nov 2017 22:47:29 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171113/c5c8c626/attachment.html>