[Asterisk-code-review] core: Use ast alertpipe for Asterisk signal monitoring thread. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7169 )

Change subject: core: Use ast_alertpipe for Asterisk signal monitoring thread.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7169/1/main/asterisk.c
File main/asterisk.c:

https://gerrit.asterisk.org/#/c/7169/1/main/asterisk.c@1769
PS1, Line 1769: 	if (ast_alertpipe_writable(sig_alert_pipe)) {
              : 		if (ast_alertpipe_write(sig_alert_pipe)) {
> ast_alertpipe_write calls ast_alertpipe_writable before trying to write, so
Hmm, I didn't realize apparently ast_alertpipe_write doesn't return an error if it's not writable.



-- 
To view, visit https://gerrit.asterisk.org/7169
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4041a237d481ff699639e153ea6982fee14a462
Gerrit-Change-Number: 7169
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 13 Nov 2017 22:39:27 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171113/d3fadde5/attachment.html>