[Asterisk-code-review] Prevent unload of modules which implement an Optional API. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6957 )

Change subject: Prevent unload of modules which implement an Optional API.
......................................................................


Patch Set 1:

tests/rest_api/asterisk/modules/get_modules appears to be an actual failure.  It checks for use_count of many modules including res_http_websocket.so.  The count is now one higher due to the shutdown ref.

Three potential solutions:
* Update the expected use_count of res_http_websocket from 2 to 3 (break test for older revisions).
* Remove the check for use_count from res_http_websocket.
* Remove the check for use_count of all modules.


-- 
To view, visit https://gerrit.asterisk.org/6957
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia07786fe655681aec49cc8d3d96e06483b11f5e6
Gerrit-Change-Number: 6957
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 02 Nov 2017 15:26:33 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171102/7fac4493/attachment.html>