[Asterisk-code-review] channel / app meetme: Fix parentheses. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed May 31 11:59:23 CDT 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/5744 )

Change subject: channel / app_meetme: Fix parentheses.
......................................................................


channel / app_meetme: Fix parentheses.

ASTERISK-27025

Change-Id: Id736b0aa4ec6b6b0f04663d64fa8d151f81fdbed
---
M apps/app_meetme.c
M main/channel.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Sean Bright: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/apps/app_meetme.c b/apps/app_meetme.c
index 36f5c77..71ca9dc 100644
--- a/apps/app_meetme.c
+++ b/apps/app_meetme.c
@@ -4661,7 +4661,7 @@
 	if (cnf) {
 		if (confflags->flags && !cnf->chan &&
 		    !ast_test_flag64(confflags, CONFFLAG_QUIET) &&
-		    ast_test_flag64(confflags, CONFFLAG_INTROUSER | CONFFLAG_INTROUSERNOREVIEW) | CONFFLAG_INTROUSER_VMREC) {
+		    ast_test_flag64(confflags, CONFFLAG_INTROUSER | CONFFLAG_INTROUSERNOREVIEW | CONFFLAG_INTROUSER_VMREC)) {
 			ast_log(LOG_WARNING, "No DAHDI channel available for conference, user introduction disabled (is chan_dahdi loaded?)\n");
 			ast_clear_flag64(confflags, CONFFLAG_INTROUSER | CONFFLAG_INTROUSERNOREVIEW | CONFFLAG_INTROUSER_VMREC);
 		}
diff --git a/main/channel.c b/main/channel.c
index 1f97e65..4451e52 100644
--- a/main/channel.c
+++ b/main/channel.c
@@ -9116,7 +9116,7 @@
 
 	if (reason->str) {
 		length = strlen(reason->str);
-		if (datalen < pos + sizeof(data[0] * 2) + length) {
+		if (datalen < pos + (sizeof(data[0]) * 2) + length) {
 			ast_log(LOG_WARNING, "No space left for %s string\n", label);
 			return -1;
 		}

-- 
To view, visit https://gerrit.asterisk.org/5744
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id736b0aa4ec6b6b0f04663d64fa8d151f81fdbed
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>



More information about the asterisk-code-review mailing list