[Asterisk-code-review] format: Reintroduce smoother flags (asterisk[14])
Sean Bright
asteriskteam at digium.com
Tue May 30 08:47:06 CDT 2017
Sean Bright has uploaded a new change for review. ( https://gerrit.asterisk.org/5730 )
Change subject: format: Reintroduce smoother flags
......................................................................
format: Reintroduce smoother flags
In review 4843 (ASTERISK-24858), we added a hack that forced a smoother
creation when sending signed linear so that the byte order was adjusted
during transmission. This was needed because smoother flags were lost
during the new format work that was done in Asterisk 13.
Rather than rolling that same hack into res_rtp_multicast, re-introduce
smoother flags so that formats can dictate their own options.
Change-Id: I77b835fba0e539c6ce50014a984766f63cab2c16
---
M include/asterisk/codec.h
M include/asterisk/format.h
M include/asterisk/smoother.h
M main/codec_builtin.c
M main/format.c
M res/res_rtp_asterisk.c
M res/res_rtp_multicast.c
7 files changed, 130 insertions(+), 56 deletions(-)
git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/30/5730/1
diff --git a/include/asterisk/codec.h b/include/asterisk/codec.h
index 3873324..e3b7106 100644
--- a/include/asterisk/codec.h
+++ b/include/asterisk/codec.h
@@ -26,6 +26,9 @@
#ifndef _AST_CODEC_H_
#define _AST_CODEC_H_
+#define AST_SMOOTHER_FLAGS_PACK(x) ((x) << 1)
+#define AST_SMOOTHER_FLAGS_UNPACK(x) ((x) >> 1)
+
/*! \brief Types of media */
enum ast_media_type {
AST_MEDIA_TYPE_UNKNOWN = 0,
diff --git a/include/asterisk/format.h b/include/asterisk/format.h
index a5ca038..fb130e8 100644
--- a/include/asterisk/format.h
+++ b/include/asterisk/format.h
@@ -338,6 +338,17 @@
int ast_format_can_be_smoothed(const struct ast_format *format);
/*!
+ * \since 13.17.0
+ *
+ * \brief Get smoother flags for this format
+ *
+ * \param format The media format
+ *
+ * \return smoother flags for the provided format
+ */
+int ast_format_get_smoother_flags(const struct ast_format *format);
+
+/*!
* \brief Get the media type of a format
*
* \param format The media format
diff --git a/include/asterisk/smoother.h b/include/asterisk/smoother.h
index e63aa77..65ac889 100644
--- a/include/asterisk/smoother.h
+++ b/include/asterisk/smoother.h
@@ -33,6 +33,7 @@
#define AST_SMOOTHER_FLAG_G729 (1 << 0)
#define AST_SMOOTHER_FLAG_BE (1 << 1)
+#define AST_SMOOTHER_FLAG_FORCED (1 << 2)
/*! \name AST_Smoother
*/
diff --git a/main/codec_builtin.c b/main/codec_builtin.c
index 4f17505..96868e6 100644
--- a/main/codec_builtin.c
+++ b/main/codec_builtin.c
@@ -38,6 +38,7 @@
#include "asterisk/format.h"
#include "asterisk/format_cache.h"
#include "asterisk/frame.h"
+#include "asterisk/smoother.h"
int __ast_codec_register_with_format(struct ast_codec *codec, const char *format_name,
struct ast_module *mod);
@@ -265,7 +266,7 @@
.minimum_bytes = 160,
.samples_count = slin_samples,
.get_length = slin_length,
- .smooth = 1,
+ .smooth = AST_SMOOTHER_FLAGS_PACK(AST_SMOOTHER_FLAG_BE | AST_SMOOTHER_FLAG_FORCED),
};
static struct ast_codec slin12 = {
@@ -279,7 +280,7 @@
.minimum_bytes = 240,
.samples_count = slin_samples,
.get_length = slin_length,
- .smooth = 1,
+ .smooth = AST_SMOOTHER_FLAGS_PACK(AST_SMOOTHER_FLAG_BE | AST_SMOOTHER_FLAG_FORCED),
};
static struct ast_codec slin16 = {
@@ -293,7 +294,7 @@
.minimum_bytes = 320,
.samples_count = slin_samples,
.get_length = slin_length,
- .smooth = 1,
+ .smooth = AST_SMOOTHER_FLAGS_PACK(AST_SMOOTHER_FLAG_BE | AST_SMOOTHER_FLAG_FORCED),
};
static struct ast_codec slin24 = {
@@ -307,7 +308,7 @@
.minimum_bytes = 480,
.samples_count = slin_samples,
.get_length = slin_length,
- .smooth = 1,
+ .smooth = AST_SMOOTHER_FLAGS_PACK(AST_SMOOTHER_FLAG_BE | AST_SMOOTHER_FLAG_FORCED),
};
static struct ast_codec slin32 = {
@@ -321,7 +322,7 @@
.minimum_bytes = 640,
.samples_count = slin_samples,
.get_length = slin_length,
- .smooth = 1,
+ .smooth = AST_SMOOTHER_FLAGS_PACK(AST_SMOOTHER_FLAG_BE | AST_SMOOTHER_FLAG_FORCED),
};
static struct ast_codec slin44 = {
@@ -335,7 +336,7 @@
.minimum_bytes = 882,
.samples_count = slin_samples,
.get_length = slin_length,
- .smooth = 1,
+ .smooth = AST_SMOOTHER_FLAGS_PACK(AST_SMOOTHER_FLAG_BE | AST_SMOOTHER_FLAG_FORCED),
};
static struct ast_codec slin48 = {
@@ -349,7 +350,7 @@
.minimum_bytes = 960,
.samples_count = slin_samples,
.get_length = slin_length,
- .smooth = 1,
+ .smooth = AST_SMOOTHER_FLAGS_PACK(AST_SMOOTHER_FLAG_BE | AST_SMOOTHER_FLAG_FORCED),
};
static struct ast_codec slin96 = {
@@ -363,7 +364,7 @@
.minimum_bytes = 1920,
.samples_count = slin_samples,
.get_length = slin_length,
- .smooth = 1,
+ .smooth = AST_SMOOTHER_FLAGS_PACK(AST_SMOOTHER_FLAG_BE | AST_SMOOTHER_FLAG_FORCED),
};
static struct ast_codec slin192 = {
@@ -377,7 +378,7 @@
.minimum_bytes = 3840,
.samples_count = slin_samples,
.get_length = slin_length,
- .smooth = 1,
+ .smooth = AST_SMOOTHER_FLAGS_PACK(AST_SMOOTHER_FLAG_BE | AST_SMOOTHER_FLAG_FORCED),
};
static int lpc10_samples(struct ast_frame *frame)
diff --git a/main/format.c b/main/format.c
index cc9ac45..e5120d7 100644
--- a/main/format.c
+++ b/main/format.c
@@ -377,7 +377,13 @@
int ast_format_can_be_smoothed(const struct ast_format *format)
{
- return format->codec->smooth;
+ /* Coalesce to 1 if non-zero */
+ return format->codec->smooth ? 1 : 0;
+}
+
+int ast_format_get_smoother_flags(const struct ast_format *format)
+{
+ return AST_SMOOTHER_FLAGS_UNPACK(format->codec->smooth);
}
enum ast_media_type ast_format_get_type(const struct ast_format *format)
diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index 8d4e50d..1d5f731 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -4012,10 +4012,10 @@
/* If no smoother is present see if we have to set one up */
if (!rtp->smoother && ast_format_can_be_smoothed(format)) {
+ unsigned int smoother_flags = ast_format_get_smoother_flags(format);
unsigned int framing_ms = ast_rtp_codecs_get_framing(ast_rtp_instance_get_codecs(instance));
- int is_slinear = ast_format_cache_is_slinear(format);
- if (!framing_ms && is_slinear) {
+ if (!framing_ms && (smoother_flags & AST_SMOOTHER_FLAG_FORCED)) {
framing_ms = ast_format_get_default_ms(format);
}
@@ -4026,9 +4026,7 @@
ast_format_get_name(format), framing_ms, ast_format_get_minimum_bytes(format));
return -1;
}
- if (is_slinear) {
- ast_smoother_set_flags(rtp->smoother, AST_SMOOTHER_FLAG_BE);
- }
+ ast_smoother_set_flags(rtp->smoother, smoother_flags);
}
}
diff --git a/res/res_rtp_multicast.c b/res/res_rtp_multicast.c
index fce4926..b81f3c6 100644
--- a/res/res_rtp_multicast.c
+++ b/res/res_rtp_multicast.c
@@ -56,6 +56,7 @@
#include "asterisk/format_cache.h"
#include "asterisk/multicast_rtp.h"
#include "asterisk/app.h"
+#include "asterisk/smoother.h"
/*! Command value used for Linksys paging to indicate we are starting */
#define LINKSYS_MCAST_STARTCMD 6
@@ -97,6 +98,7 @@
uint16_t seqno;
unsigned int lastts;
struct timeval txcore;
+ struct ast_smoother *smoother;
};
enum {
@@ -397,9 +399,53 @@
multicast_send_control_packet(instance, multicast, LINKSYS_MCAST_STOPCMD);
}
+ if (multicast->smoother) {
+ ast_smoother_free(multicast->smoother);
+ }
+
close(multicast->socket);
ast_free(multicast);
+
+ return 0;
+}
+
+static int ast_rtp_raw_write(struct ast_rtp_instance *instance, struct ast_frame *frame, int codec)
+{
+ struct multicast_rtp *multicast = ast_rtp_instance_get_data(instance);
+ unsigned int ms = calc_txstamp(multicast, &frame->delivery);
+ unsigned char *rtpheader;
+ struct ast_sockaddr remote_address = { {0,} };
+ int rate = rtp_get_rate(frame->subclass.format) / 1000;
+ int hdrlen = 12;
+
+ /* Calculate last TS */
+ multicast->lastts = multicast->lastts + ms * rate;
+
+ /* Construct an RTP header for our packet */
+ rtpheader = (unsigned char *)(frame->data.ptr - hdrlen);
+ put_unaligned_uint32(rtpheader, htonl((2 << 30) | (codec << 16) | (multicast->seqno)));
+
+ if (ast_test_flag(frame, AST_FRFLAG_HAS_TIMING_INFO)) {
+ put_unaligned_uint32(rtpheader + 4, htonl(frame->ts * 8));
+ } else {
+ put_unaligned_uint32(rtpheader + 4, htonl(multicast->lastts));
+ }
+
+ put_unaligned_uint32(rtpheader + 8, htonl(multicast->ssrc));
+
+ /* Increment sequence number and wrap to 0 if it overflows 16 bits. */
+ multicast->seqno = 0xFFFF & (multicast->seqno + 1);
+
+ /* Finally send it out to the eager phones listening for us */
+ ast_rtp_instance_get_remote_address(instance, &remote_address);
+
+ if (ast_sendto(multicast->socket, (void *) rtpheader, frame->datalen + hdrlen, 0, &remote_address) < 0) {
+ ast_log(LOG_ERROR, "Multicast RTP Transmission error to %s: %s\n",
+ ast_sockaddr_stringify(&remote_address),
+ strerror(errno));
+ return -1;
+ }
return 0;
}
@@ -408,12 +454,9 @@
static int multicast_rtp_write(struct ast_rtp_instance *instance, struct ast_frame *frame)
{
struct multicast_rtp *multicast = ast_rtp_instance_get_data(instance);
- struct ast_frame *f = frame;
- struct ast_sockaddr remote_address;
- int hdrlen = 12, res = 0, codec;
- unsigned char *rtpheader;
- unsigned int ms = calc_txstamp(multicast, &frame->delivery);
- int rate = rtp_get_rate(frame->subclass.format) / 1000;
+ struct ast_format *format;
+ struct ast_frame *f;
+ int codec;
/* We only accept audio, nothing else */
if (frame->frametype != AST_FRAME_VOICE) {
@@ -427,45 +470,56 @@
return -1;
}
- /* If we do not have space to construct an RTP header duplicate the frame so we get some */
- if (frame->offset < hdrlen) {
- f = ast_frdup(frame);
+ format = frame->subclass.format;
+ if (!multicast->smoother && ast_format_can_be_smoothed(format)) {
+ unsigned int smoother_flags = ast_format_get_smoother_flags(format);
+ unsigned int framing_ms = ast_rtp_codecs_get_framing(ast_rtp_instance_get_codecs(instance));
+
+ if (!framing_ms && (smoother_flags & AST_SMOOTHER_FLAG_FORCED)) {
+ framing_ms = ast_format_get_default_ms(format);
+ }
+
+ if (framing_ms) {
+ multicast->smoother = ast_smoother_new((framing_ms * ast_format_get_minimum_bytes(format)) / ast_format_get_minimum_ms(format));
+ if (!multicast->smoother) {
+ ast_log(LOG_WARNING, "Unable to create smoother: format %s ms: %u len %u\n",
+ ast_format_get_name(format), framing_ms, ast_format_get_minimum_bytes(format));
+ return -1;
+ }
+ ast_smoother_set_flags(multicast->smoother, smoother_flags);
+ }
}
-
- /* Calucate last TS */
- multicast->lastts = multicast->lastts + ms * rate;
-
- /* Construct an RTP header for our packet */
- rtpheader = (unsigned char *)(f->data.ptr - hdrlen);
- put_unaligned_uint32(rtpheader, htonl((2 << 30) | (codec << 16) | (multicast->seqno)));
-
- if (ast_test_flag(f, AST_FRFLAG_HAS_TIMING_INFO)) {
- put_unaligned_uint32(rtpheader + 4, htonl(f->ts * 8));
+
+ if (multicast->smoother) {
+ if (ast_smoother_test_flag(multicast->smoother, AST_SMOOTHER_FLAG_BE)) {
+ ast_smoother_feed_be(multicast->smoother, frame);
+ } else {
+ ast_smoother_feed(multicast->smoother, frame);
+ }
+
+ while ((f = ast_smoother_read(multicast->smoother)) && f->data.ptr) {
+ ast_rtp_raw_write(instance, f, codec);
+ }
} else {
- put_unaligned_uint32(rtpheader + 4, htonl(multicast->lastts));
+ int hdrlen = 12;
+
+ /* If we do not have space to construct an RTP header duplicate the frame so we get some */
+ if (frame->offset < hdrlen) {
+ f = ast_frdup(frame);
+ } else {
+ f = frame;
+ }
+
+ if (f->data.ptr) {
+ ast_rtp_raw_write(instance, f, codec);
+ }
+
+ if (f != frame) {
+ ast_frfree(f);
+ }
}
- put_unaligned_uint32(rtpheader + 8, htonl(multicast->ssrc));
-
- /* Increment sequence number and wrap to 0 if it overflows 16 bits. */
- multicast->seqno = 0xFFFF & (multicast->seqno + 1);
-
- /* Finally send it out to the eager phones listening for us */
- ast_rtp_instance_get_remote_address(instance, &remote_address);
-
- if (ast_sendto(multicast->socket, (void *) rtpheader, f->datalen + hdrlen, 0, &remote_address) < 0) {
- ast_log(LOG_ERROR, "Multicast RTP Transmission error to %s: %s\n",
- ast_sockaddr_stringify(&remote_address),
- strerror(errno));
- res = -1;
- }
-
- /* If we were forced to duplicate the frame free the new one */
- if (frame != f) {
- ast_frfree(f);
- }
-
- return res;
+ return 0;
}
/*! \brief Function called to read from a multicast instance */
--
To view, visit https://gerrit.asterisk.org/5730
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77b835fba0e539c6ce50014a984766f63cab2c16
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
More information about the asterisk-code-review
mailing list